Skip to content

bad api key doesnt block #919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bboynton97 merged 4 commits into from
Apr 15, 2025
Merged

bad api key doesnt block #919

bboynton97 merged 4 commits into from
Apr 15, 2025

Conversation

@bboynton97
Copy link
Contributor

@bboynton97 bboynton97 commented Apr 11, 2025

image

Allows the agent to run without AgentOps if the API key is invalid

@bboynton97 bboynton97 requested review from Dwij1704 and tcdent April 11, 2025 21:06
@codecov
Copy link

codecov bot commented Apr 11, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 40.00000% with 30 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
agentops/legacy/__init__.py 42.85% 16 Missing ⚠️
agentops/client/api/versions/v3.py 35.00% 13 Missing ⚠️
agentops/client/client.py 50.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@Dwij1704
Copy link
Member

Dwij1704 commented Apr 11, 2025

We have two ways a user can use agentops

agentops.init()

or

agentops.init(auto_start_session=False)
agentops.start_session()

The fix doesn't work for the second one
image

@Dwij1704
Copy link
Member

Dwij1704 commented Apr 11, 2025

We have two ways a user can use agentops

agentops.init()

or

agentops.init(auto_start_session=False)
agentops.start_session()

The fix doesn't work for the second one image

Fixed the same

@bboynton97 bboynton97 merged commit 507a386 into main Apr 15, 2025
7 of 10 checks passed
@bboynton97 bboynton97 deleted the api-key-not-blocking branch April 15, 2025 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Dwij1704 Dwij1704 Dwij1704 approved these changes

@tcdent tcdent Awaiting requested review from tcdent

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bboynton97 @Dwij1704